[Translation] Handling Events by niyabits · Pull Request #27 · reactjs/hi.react.dev

niyabits · 2019-03-24T14:26:56Z

1. First Section
2. Try it on CodePen
3. Passing Arguments to Event Handlers {#passing-arguments-to-event-handlers}

netlify · 2019-03-24T14:33:09Z

Deploy preview for hi-reactjs ready!

Built with commit 398b05e

https://deploy-preview-27--hi-reactjs.netlify.com

arshadkazmi42 · 2019-03-29T18:17:59Z

@yashguptaz Just want to check in, if you are waiting for review for this. I would suggest have at least 1 section translated for review.

niyabits · 2019-03-30T15:44:54Z

I will proceed with this tomorrow, I'm busy with some client work right now.

arshadkazmi42 · 2019-04-05T02:20:00Z

@yashguptaz Just ping me whenever you want me to start the review

niyabits · 2019-04-14T16:43:43Z

@arshadkazmi42 Can you review now as I have completed one section?

arshadkazmi42

Good start.
I have added a couple of comments.
We can close on the review of this section, then you can proceed with further translations

arshadkazmi42 · 2019-04-19T04:25:59Z

@yashguptaz There's a couple of things missed, once you are done with those, you can continue working on rest of the page translation

arshadkazmi42 · 2019-05-05T12:52:55Z

@yashguptaz Any updates on this?

niyabits · 2019-05-10T07:12:13Z

No, I'm busy these days that's why I am not able to do any further translations.

niyabits · 2019-05-19T16:51:54Z

@arshadkazmi42 Can you review please?
I am free now for a few days, let's get this done.
Sorry for inactivity.

arshadkazmi42 · 2019-05-19T18:02:20Z

@yashguptaz Good to see you back.
There are few pending feedbacks which are not fixed yet, once you are done fixing those, I can continue the review of rest of the page

https://github.com/reactjs/hi.reactjs.org/pull/27/files/d07d51d6b61c384e2e12da9c459236f6266d9705#diff-8ca12b03172ba3c2192ea86202f08231R14

https://github.com/reactjs/hi.reactjs.org/pull/27/files/d07d51d6b61c384e2e12da9c459236f6266d9705#diff-8ca12b03172ba3c2192ea86202f08231R57

saranshkataria · 2019-06-17T17:55:26Z

@yashguptaz any updates on this?

niyabits · 2019-06-18T03:47:25Z

@saranshkataria No, I am not finding out much time to work on it :/

saranshkataria · 2019-10-04T21:14:20Z

@yashguptaz let us know if you will be able to spare time to complete this, else we will be closing this PR out

niyabits · 2019-10-07T17:53:52Z

@arshadkazmi42
I have fixed and marked 👍 to every issue.
@saranshkataria
You can start with the 2nd phase of review after the above issues are marked as resolved by @arshadkazmi42

saranshkataria · 2019-10-07T18:48:37Z

@arshadkazmi42 let me know if you are done :)

arshadkazmi42

Great work. Thank you for working on all those feedbacks 👍
@saranshkataria you can start with the 2nd phase of the review.

niyabits · 2019-10-08T14:22:57Z

@saranshkataria Mention me once you're done with the phase 2 review.

niyabits · 2019-10-11T14:38:42Z

@saranshkataria are you done with reviewing? Please do it fast, I have to manage it all with my school and coaching.

saranshkataria · 2019-10-14T17:30:51Z

-* React events are named using camelCase, rather than lowercase.
-* With JSX you pass a function as the event handler, rather than a string.
+* React के इवेंट्स का नाम lowercase कि जगह camelCase में रक्खा जाता है ।
+* JSX का उपयोग करते समय, आप एक function को string की जगह इवेंट हैंडलर में पास करते हैं ।


changes the context of the sentence, rewrite it in a better way perhaps?

saranshkataria · 2019-10-14T17:36:27Z

added comments till line 94

niyabits · 2019-11-17T03:58:52Z

@saranshkataria Can you proceed with the review process?

saranshkataria · 2019-11-17T19:02:23Z

 ```

-Here, `e` is a synthetic event. React defines these synthetic events according to the [W3C spec](https://www.w3.org/TR/DOM-Level-3-Events/), so you don't need to worry about cross-browser compatibility. See the [`SyntheticEvent`](/docs/events.html) reference guide to learn more.
+यहाँ पर `e` एक सिंथेटिक इवेंट है । React इन सिंथेटिक इवेंट्स को [W3C spec](https://www.w3.org/TR/DOM-Level-3-Events/) के हिसाब से परिभाषित करता है, ताकी आपको cross-browser compatibility कि चिंता नही करनी पड़े । और सीखने के लिए [`SyntheticEvent`](/docs/events.html) की रिफरेन्स गाइड को देखें ।


नही करनी पड़े -> na karni

saranshkataria · 2019-11-17T19:04:17Z

+जब आप [ES6 class](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes) से एक कौम्पोनॅन्ट डिफाइन करते हैं, तो इसके लिए इवेंट हैंडलर को उस क्लास का मेथड होना एक आम पैटर्न है । उद्धरण के तौर पर `Toggle` कॉम्पोनेन्ट एक बटन को रेंडर करता है, ये बटन यूज़र को "ON" और "OFF" states को बदलने देता है:

 ```js{6,7,10-14,18}
 class Toggle extends React.Component {


translate comments as well?

saranshkataria · 2019-11-17T19:04:52Z

+[**इससे CodePen पर इस्तेमाल करें**](https://codepen.io/gaearon/pen/xEmzGg?editors=0010)

-You have to be careful about the meaning of `this` in JSX callbacks. In JavaScript, class methods are not [bound](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind) by default. If you forget to bind `this.handleClick` and pass it to `onClick`, `this` will be `undefined` when the function is actually called.
+JSX callbacks आपको `this` के मतलब के साथ ध्यानपूर्वक रहना चाहिए । जावास्क्रिप्ट में class मेथड्स पहले से [bound](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind) नहीं होते । अगर आप `this.handleClick` को bind करना भूल जाते हैं और उसे `onClick` पर पास कर देते हैं तो, `this` function के बुलाने पर `undefined` हो जाता है ।


JSX callbacks आपको this के मतलब के साथ ध्यानपूर्वक रहना चाहिए । -> incorrect sentence structure

बुलाने पर undefined हो जाता है । -> could be worded better?

saranshkataria · 2019-11-17T19:05:53Z

+JSX callbacks आपको `this` के मतलब के साथ ध्यानपूर्वक रहना चाहिए । जावास्क्रिप्ट में class मेथड्स पहले से [bound](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind) नहीं होते । अगर आप `this.handleClick` को bind करना भूल जाते हैं और उसे `onClick` पर पास कर देते हैं तो, `this` function के बुलाने पर `undefined` हो जाता है ।

-This is not React-specific behavior; it is a part of [how functions work in JavaScript](https://www.smashingmagazine.com/2014/01/understanding-javascript-function-prototype-bind/). Generally, if you refer to a method without `()` after it, such as `onClick={this.handleClick}`, you should bind that method.
+यह बर्ताव React कि वजेह से नहीं होता बल्कि यह [जावास्क्रिप्ट के functions के काम करने के तरीके का एक भाग है ](https://www.smashingmagazine.com/2014/01/understanding-javascript-function-prototype-bind/). आम तौर पर अगर आप किसी मेथड को बिना `()` को उसके बाद में लगाये refer करते है, जैसे, `onClick={this.handleClick}` तो आपको वो मेथड bind करना चाहिए ।


कि वजेह -> spelling of both words is incorrect

आम तौर पर अगर आप किसी मेथड को बिना () को उसके बाद में लगाये refer करते है, जैसे, onClick={this.handleClick} तो आपको वो मेथड bind करना चाहिए । revisit sentence structure

saranshkataria · 2019-11-17T19:07:01Z

+अगर `bind` का बार बार कॉल करना आपको परेशान करता है, तो इससे बचने के आपके पास दो तरीके हैं । अगर आप experimental [public class फ़ील्ड्स सिंटेक्स](https://babeljs.io/docs/plugins/transform-class-properties/) इस्तेमाल कर रहे हैं, तो आप class फ़ील्ड्स का इस्तेमाल करके callbacks को सही से bind कर सकते हैं:

 ```js{2-6}
 class LoggingButton extends React.Component {


translate comments?

saranshkataria · 2019-11-17T19:07:21Z

 ```

-This syntax is enabled by default in [Create React App](https://github.com/facebookincubator/create-react-app).
+यह सिंटैक्स [Create React App](https://github.com/facebookincubator/create-react-app) में डिफ़ॉल्ट रूप में पाया जाता है। 


में डिफ़ॉल्ट रूप में पाया जाता है। -> better wording?

saranshkataria · 2019-11-17T19:07:48Z

+अगर आप class फील्ड सिंटैक्स नहीं इस्तेमाल कर रहें हैं तो आप callback में [एरो फंक्शन](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Functions/Arrow_functions) का इस्तेमाल कर सकते हैं। 

 ```js{7-9}
 class LoggingButton extends React.Component {


comments again

saranshkataria · 2019-11-17T19:08:32Z

added comments till {#passing-arguments-to-event-handlers}

arshadkazmi42 · 2023-06-05T11:05:24Z

Closing due to inactivity

[Translation] Line 11 - Initial Commit

6bf2280

tesseralis mentioned this pull request Mar 24, 2019

[OLD] Legacy Hindi Translation Progress #1

Closed

88 tasks

niyabits changed the title ~~[Translation] Line 11 - Initial Commit~~ [Translation] Handling Events Mar 26, 2019

Merge branch 'master' into patch-2

4e29e91

niyabits added 2 commits March 30, 2019 22:52

[Translation] Till Line 24

6df36d9

[Translation] Till Line 36

cbe5eab

saranshkataria added the awaiting author response label Apr 12, 2019

[Translation] Section 1 Completed.

d07d51d

arshadkazmi42 requested changes Apr 15, 2019

View reviewed changes

arshadkazmi42 and others added 2 commits April 15, 2019 08:24

Merge branch 'master' into patch-2

e025f13

[Review] Till Line 61

80c15da

arshadkazmi42 added 2 commits April 19, 2019 09:56

Merge branch 'master' into patch-2

8a73261

Merge branch 'master' into patch-2

6705144

Merge branch 'master' into patch-2

0ae1332

[Translation] Till Line 100

2515e95

Merge branch 'master' into patch-2

52ec343

Merge branch 'master' into patch-2

f3d0d3b

[Review] 01 Corrected till line 154

087478e

arshadkazmi42 approved these changes Oct 7, 2019

View reviewed changes

saranshkataria reviewed Oct 14, 2019

View reviewed changes

Comment thread content/docs/handling-events.md Outdated

saranshkataria reviewed Oct 14, 2019

View reviewed changes

Comment thread content/docs/handling-events.md Outdated

saranshkataria reviewed Oct 14, 2019

View reviewed changes

Comment thread content/docs/handling-events.md Outdated

saranshkataria reviewed Oct 14, 2019

View reviewed changes

Comment thread content/docs/handling-events.md Outdated

Merge branch 'master' into patch-2

9cec71a

[Review] Till line 61

cf88b1f

saranshkataria reviewed Nov 17, 2019

View reviewed changes

saranshkataria added 2 commits November 17, 2019 11:08

Merge branch 'master' into patch-2

69ddcf2

Merge branch 'master' into patch-2

398b05e

saranshkataria added the awaiting author response label Jan 7, 2020

arshadkazmi42 added the 2nd Review Second phrase of review label Jan 24, 2020

arshadkazmi42 added the stale label Jun 5, 2023

arshadkazmi42 closed this Jun 5, 2023

Uh oh!

Conversation

niyabits commented Mar 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Mar 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arshadkazmi42 commented Mar 29, 2019

Uh oh!

niyabits commented Mar 30, 2019

Uh oh!

arshadkazmi42 commented Apr 5, 2019

Uh oh!

niyabits commented Apr 14, 2019

Uh oh!

arshadkazmi42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arshadkazmi42 commented Apr 19, 2019

Uh oh!

arshadkazmi42 commented May 5, 2019

Uh oh!

niyabits commented May 10, 2019

Uh oh!

niyabits commented May 19, 2019

Uh oh!

arshadkazmi42 commented May 19, 2019

Uh oh!

saranshkataria commented Jun 17, 2019

Uh oh!

niyabits commented Jun 18, 2019

Uh oh!

saranshkataria commented Oct 4, 2019

Uh oh!

niyabits commented Oct 7, 2019

Uh oh!

saranshkataria commented Oct 7, 2019

Uh oh!

arshadkazmi42 left a comment

Choose a reason for hiding this comment

Uh oh!

niyabits commented Oct 8, 2019

Uh oh!

niyabits commented Oct 11, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saranshkataria commented Oct 14, 2019

Uh oh!

niyabits commented Nov 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

niyabits commented Mar 24, 2019 •

edited

Loading

netlify Bot commented Mar 24, 2019 •

edited

Loading